Re: Broken SSL tests in master - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Broken SSL tests in master
Date
Msg-id CAB7nPqTbFkPo5G9YkJ4=smkuNUKC_+YJTbyCF8EW+E5e20Rgzg@mail.gmail.com
Whole thread Raw
In response to Re: Broken SSL tests in master  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Fri, Dec 2, 2016 at 5:56 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Fri, Nov 25, 2016 at 4:16 AM, Mithun Cy <mithun.cy@enterprisedb.com> wrote:
>> Reason is we first decode the URI(percent encoded character) then try to
>> split the string into multiple host assuming they are separated by ','. I
>> think we need to change the order here. Otherwise difficult the say whether
>> ',' is part of USD path or a separator.
>
> Yeah, we should change that.  Are you going to write a patch?

The interesting bit in rfc3986:
  Aside from dot-segments in hierarchical paths, a path segment is  considered opaque by the generic syntax.  URI
producingapplications  often use the reserved characters allowed in a segment to delimit  scheme-specific or
dereference-handler-specificsubcomponents.  For  example, the semicolon (";") and equals ("=") reserved characters are
oftenused to delimit parameters and parameter values applicable to  that segment.  The comma (",") reserved character
isoften used for  similar purposes.  For example, one URI producer might use a segment  such as "name;v=1.1" to
indicatea reference to version 1.1 of  "name", whereas another might use a segment such as "name,1.1" to  indicate the
same. Parameter types may be defined by scheme-specific  semantics, but in most cases the syntax of a parameter is
specificto  the implementation of the URI's dereferencing algorithm.
 

So not being able to distinguish commas in names and separators is
clearly a bug.
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Broken SSL tests in master
Next
From: Michael Paquier
Date:
Subject: Re: Broken SSL tests in master