Dereferenced pointer checks in data.c of ECPG - Mailing list pgsql-hackers

From Michael Paquier
Subject Dereferenced pointer checks in data.c of ECPG
Date
Msg-id CAB7nPqTVc7_LYQXnqhuEf+u-_EGzo5tiPZYdfems2+i9hsJmHw@mail.gmail.com
Whole thread Raw
Responses Re: Dereferenced pointer checks in data.c of ECPG  (Michael Meskes <meskes@postgresql.org>)
List pgsql-hackers
Hi all,

ecpg_get_data@data.c is using to null-pointer checks for pval but it happens that we have the guarantee that those pointers are never NULL, see for example this piece of code at the code of ecpg_get_data():
        /* pval is a pointer to the value */
        if (!pval)
        {
                /*
                 * This should never happen because we already checked that we found
                 * at least one tuple, but let's play it safe.
                 */
                ecpg_raise(lineno, ECPG_NOT_FOUND, ECPG_SQLSTATE_NO_DATA, NULL);
                return (false);
        }
A patch is attached, and the issue has been spotted by Coverity.
Regards,
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Precedence of standard comparison operators
Next
From: Mark Kirkwood
Date:
Subject: Re: Unable to build pg_rewind