Re: WAL consistency check facility - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: WAL consistency check facility
Date
Msg-id CAB7nPqTU78C7jmPeoHmkDws-PQ-KPtsssFOjiiiBdQtEuxrVyw@mail.gmail.com
Whole thread Raw
In response to Re: WAL consistency check facility  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: WAL consistency check facility  (Kuntal Ghosh <kuntalghosh.2007@gmail.com>)
List pgsql-hackers
On Thu, Nov 3, 2016 at 4:04 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> Wouldn't the definition of a new redo action make sense then? Say
> SKIPPED. None of the existing actions match the non-apply case.

I just took 5 minutes to look at the code and reason about it, and
something like what your patch is doing would be actually fine. Still
I don't think that checking for the apply flag in the macro routine
should look for has_image. Let's keep things separate.
-- 
Michael



pgsql-hackers by date:

Previous
From: Kuntal Ghosh
Date:
Subject: Re: WAL consistency check facility
Next
From: Kuntal Ghosh
Date:
Subject: Re: WAL consistency check facility