Re: Add shutdown_at_recovery_target option to recovery.conf - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add shutdown_at_recovery_target option to recovery.conf
Date
Msg-id CAB7nPqTQJ5BuKn=sDAfxzDqcCfq8sVcic894jR-Vp78nTUHABA@mail.gmail.com
Whole thread
In response to Re: Add shutdown_at_recovery_target option to recovery.conf  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers


On Sat, Dec 6, 2014 at 12:49 AM, Robert Haas <robertmhaas@gmail.com> wrote:
On Thu, Dec 4, 2014 at 8:45 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
>> Here is patch which renames action_at_recovery_target to
>> recovery_target_action everywhere.
> Thanks, Looks good to me.
>
> A couple of things that would be good to document as well in
> recovery-config.sgml:
> - the fact that pause_at_recovery_target is deprecated.

Why not just remove it altogether?  I don't think the
backward-compatibility break is enough to get excited about, or to
justify the annoyance of carrying an extra parameter that does (part
of) the same thing.
At least we won't forget removing in the future something that has been marked as deprecated for years. So +1 here for a simple removal, and a mention in the future release notes.
--
Michael

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: INSERT ... ON CONFLICT {UPDATE | IGNORE}
Next
From: Robert Haas
Date:
Subject: Re: On partitioning