Re: improved DefElem list processing - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: improved DefElem list processing
Date
Msg-id CAB7nPqTNqY0G_oAcW9yepXd0ArvZgUaQd4XhHBqBD-qjdqMgOg@mail.gmail.com
Whole thread Raw
In response to Re: improved DefElem list processing  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
On Mon, Aug 22, 2016 at 10:41 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
> 1. This patch introduce location in DefElement node, and inject ParserState
> to SQL commands, where ParserState was not used. It allows to show the
> position of an error. This patch is not small, but almost changes are
> trivial.
>
> 2. There are no problems with patching, compiling, tests - all tests passed.
>
> 3. There is not any new functionality, so new tests and new documentation is
> not necessary.
>
> I'll mark this patch as ready for commiter.

Now that I look at those patches, +1 for both. Particularly the
redundant-option checks will remove a lot of boring code.
-- 
Michael



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: dsm_unpin_segment
Next
From: Alvaro Herrera
Date:
Subject: Re: improved DefElem list processing