Re: [HACKERS] Race conditions with WAL sender PID lookups - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Race conditions with WAL sender PID lookups
Date
Msg-id CAB7nPqTJPWzATLRSiuG3K-EgC9GmXLhC28MTugFvbP433KyU=w@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Race conditions with WAL sender PID lookups  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
On Tue, Jul 4, 2017 at 1:34 PM, Noah Misch <noah@leadboat.com> wrote:
> Bundling code cleanup into commits that also do something else is strictly
> worse than bundling whitespace cleanup, which is itself bad:
> https://postgr.es/m/flat/20160113144826.GB3379802@tornado.leadboat.com

FWIW, I agree with that. I favor as well separate commits for cleanups
and for fixes, so as each commit has its own goal and protects it.

(The cleanups discussed on this thread have been partially done in
commit 572d6ee where a bug has been fixed, not by me on the patches I
submitted ;) )
-- 
Michael



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: [HACKERS] Fix header comment of streamutil.c
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] pg_stop_backup(wait_for_archive := true) on standby server