Re: Correction for replication slot creation error message in 9.6 - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Correction for replication slot creation error message in 9.6
Date
Msg-id CAB7nPqTAhp4QSkPkNQnXGRDVzVg8atHbMokqD0dWmHeSf9f+QA@mail.gmail.com
Whole thread Raw
In response to Correction for replication slot creation error message in 9.6  (Ian Barwick <ian@2ndquadrant.com>)
List pgsql-hackers
On Thu, Mar 31, 2016 at 10:15 AM, Ian Barwick <ian@2ndquadrant.com> wrote:
> Currently pg_create_physical_replication_slot() may refer to
> the deprecated wal_level setting "archive":

(Adding Peter in CC who committed this patch).

> Patch changes the error message to:
>
>   ERROR:  replication slots can only be used if wal_level is "replica" or "logical"

Sounds right to me.

> Explicitly naming the valid WAL levels matches the wording in the wal_level
> error hint used in a couple of places, i.e.
>
>   "wal_level must be set to "replica" or "logical" at server start."

It is worth telling that Peter and I both had this code in front of
our eyes during the review :) Still we missed that.
-- 
Michael



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Please correct/improve wiki page about abbreviated keys bug
Next
From: David Steele
Date:
Subject: Re: Updated backup APIs for non-exclusive backups