Re: [BUGS] BUG #14230: Wrong timeline returned by pg_stop_backup on a standby - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [BUGS] BUG #14230: Wrong timeline returned by pg_stop_backup on a standby
Date
Msg-id CAB7nPqT=sLupjo6f-DKoAGN0y88-78XDZ3chQ9jV9833Wc4XwQ@mail.gmail.com
Whole thread Raw
In response to Re: [BUGS] BUG #14230: Wrong timeline returned by pg_stop_backup on a standby  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [BUGS] BUG #14230: Wrong timeline returned by pg_stop_backup on a standby  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On Mon, Jul 11, 2016 at 7:01 PM, Magnus Hagander <magnus@hagander.net> wrote:
> But isn't this also a pre-existing bug in 9.5? Or did we change something
> else that suddenly made it visible?

What has been patched here is a defect caused by pg_start_backup(),
and not pg_basebackup. In the case of the latter, ThisTimelineID gets
set by GetStandbyFlushRecPtr() in the context of the WAL sender used
to send the base backup. In short, this is only a defect of 9.6, where
pg_start_backup() can be used on standbys for the first time for
non-exclusive backups.

So the issue does not actually pre-exist, GetStandbyFlushRecPtr()
playing its role to set up the timeline ID.
-- 
Michael



pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: PSA: Systemd will kill PostgreSQL
Next
From: Magnus Hagander
Date:
Subject: Re: [BUGS] BUG #14230: Wrong timeline returned by pg_stop_backup on a standby