Postgres Pro
Downloads
Home   >   mailing lists

Code inconsistency in convert.c for guid -> string conversion - Mailing list pgsql-odbc

From Michael Paquier
Subject Code inconsistency in convert.c for guid -> string conversion
Date
Msg-id CAB7nPqT=nDYF4_D6+X00iMbYhDYCOVQqpgfE80i_Dni3zZQnJw@mail.gmail.com
Whole thread Raw
Responses Re: Code inconsistency in convert.c for guid -> string conversion  (Michael Paquier <michael.paquier@gmail.com>)
Re: Code inconsistency in convert.c for guid -> string conversion  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-odbc
Tree view 
Hi all,

While working on the code of odbc, I noticed an inconsistency in
convert.c, found by compiling the code with -Werror.

convert.c:4466: error: format '%08lX' expects type 'long unsigned
int', but argument 4 has type 'DWORD'

By looking closer at the code, the behavior in the code for guid ->
string conversion is inconsistent with char2guid using an sscan for
the similar reverse operation. I am attaching a patch fixing that.

On another note, I found as well the following warning:
dlg_specific.c:1491: error: the address of 'conn_settings' will always
evaluate as 'true'
All of this was reproduced using 09.03.0200.

Regards,
--
Michael
Attachment

pgsql-odbc by date:

Previous
From: "Inoue, Hiroshi"
Date:
Subject: Re: 09.03.0200 test failures
Next
From: Michael Paquier
Date:
Subject: Re: Code inconsistency in convert.c for guid -> string conversion