Request a Demo
Home   >   mailing lists

Re: [PATCH 05/14] Add a new relmapper.c function RelationMapFilenodeToOid that acts as a reverse of RelationMapOidToFilenode - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH 05/14] Add a new relmapper.c function RelationMapFilenodeToOid that acts as a reverse of RelationMapOidToFilenode
Date
Msg-id CAB7nPqSyW9MV_xyUtY4XEEumKcCYZLG-RBBHWUuWDJOf0HY34g@mail.gmail.com
Whole thread Raw
In response to [PATCH 05/14] Add a new relmapper.c function RelationMapFilenodeToOid that acts as a reverse of RelationMapOidToFilenode  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: [PATCH 05/14] Add a new relmapper.c function RelationMapFilenodeToOid that acts as a reverse of RelationMapOidToFilenode
List pgsql-hackers
Tree view
Hi,

This patch looks OK.

I got 3 comments:
1) Why changing the OID of pg_class_tblspc_relfilenode_index from 3171 to 3455? It does not look necessary.
2) You should perhaps change the header of RelationMapFilenodeToOid so as not mentionning it as the opposite operation of RelationMapOidToFilenode but as an operation that looks for the OID of a relation based on its relfilenode. Both functions are opposite but independent.
3) Both functions are doing similar operations. Could it be possible to wrap them in the same central function?

On Thu, Nov 15, 2012 at 10:17 AM, Andres Freund <andres@2ndquadrant.com> wrote:
---
 src/backend/utils/cache/relmapper.c | 53 +++++++++++++++++++++++++++++++++++++
 src/include/catalog/indexing.h      |  4 +--
 src/include/utils/relmapper.h       |  2 ++
 3 files changed, 57 insertions(+), 2 deletions(-)



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers




--
Michael Paquier
http://michael.otacoo.com

pgsql-hackers by date:

Previous
From: Pavan Deolasee
Date:
Subject: Re: Problem Observed in behavior of Create Index Concurrently and Hot Update
Next
From: Tom Lane
Date:
Subject: Re: WIP patch: add (PRE|POST)PROCESSOR options to COPY