Re: tracking commit timestamps - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: tracking commit timestamps
Date
Msg-id CAB7nPqSy=xyUULe+VtvcjVxV-Fe1tQwet6vub8GKAiFU3z8jag@mail.gmail.com
Whole thread
In response to Re: tracking commit timestamps  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: tracking commit timestamps
Re: tracking commit timestamps
List pgsql-hackers


On Tue, Nov 4, 2014 at 5:05 PM, Andres Freund <andres@2ndquadrant.com> wrote:
On 2014-11-02 19:27:25 +0100, Petr Jelinek wrote:
> Well, Michael has point that the extradata is pretty much useless currently,
> perhaps it would help to add the interface to set extradata?

Only accessible via C and useless aren't the same thing. But sure, add
it.
I'm still on a -1 for that. You mentioned that there is perhaps no reason to delay a decision on this matter, but IMO there is no reason to rush either in doing something we may regret. And I am not the only one on this thread expressing concern about this extra data thingy.

If this extra data field is going to be used to identify from which node a commit comes from, then it is another feature than what is written on the subject of this thread. In this case let's discuss it in the thread dedicated to replication identifiers, or come up with an extra patch once the feature for commit timestamps is done.
--
Michael

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: tracking commit timestamps
Next
From: Michael Paquier
Date:
Subject: Re: tracking commit timestamps