On Sat, Jan 28, 2017 at 8:04 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Sat, Jan 28, 2017 at 7:29 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Thu, Jan 26, 2017 at 8:53 PM, Michael Paquier
>> <michael.paquier@gmail.com> wrote:
>>>> I've not done like the most careful review ever, but I'm in favor of the
>>>> general change (provided the byval thing is fixed obviously).
>>>
>>> Thanks for the review.
>>
>> Why not use pg_ltoa and pg_lltoa like the output functions for the datatype do?
>
> No particular reason.
>
>> Might use CStringGetTextDatum(blah) instead of
>> PointerGetDatum(cstring_to_text(blah)).
>
> Yes, thanks.
I am going to create a new thread for this refactoring patch, as
that's different than the goal of this thread.
Now, regarding the main patch. Per the status of the last couple of
days, the patch has received a review but no new versions, so I am
marking it as returned with feedback for now. Feel free to update the
status of the patch to something else if you think that's more
adapted.
--
Michael
