Re: Wrong definition of pgwin32_bind. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Wrong definition of pgwin32_bind.
Date
Msg-id CAB7nPqSov2QSfrVsPEKe-TDik5Bk_gPayLaxfy7ntz5Odi-7iQ@mail.gmail.com
Whole thread Raw
In response to Wrong definition of pgwin32_bind.  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: Wrong definition of pgwin32_bind.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Apr 14, 2016 at 5:15 PM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> Hello.
>
> VC complains that pgwin32_bind() had a parameter differs in
> levels of indirection from definition. pgwin32_bind() in
> src/backend/port/win32/socket.c is defined as the following.
>
>> int pgwin32_bind(SOCKET s, struct sockaddr * addr, int *addrlen);
>
> The third parameter should be int, not int*. It might have been
> confused with pgwin32_accept.
>
> The attached patch fixes this.

Nice catch.
-- 
Michael



pgsql-hackers by date:

Previous
From: "Daniel Verite"
Date:
Subject: Re: \crosstabview fixes
Next
From: Stephen Frost
Date:
Subject: Re: SEGFAULT in CREATE EXTENSION related pg_init_privs