Re: [HACKERS] src/test/subscription/t/005_encoding.pl is broken - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] src/test/subscription/t/005_encoding.pl is broken
Date
Msg-id CAB7nPqSbumuxRAJ-Kz3jVR17pewOVFReJw_PyV8ye7oFZSDzzA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] src/test/subscription/t/005_encoding.pl is broken  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] src/test/subscription/t/005_encoding.pl is broken
List pgsql-hackers
On Wed, Sep 20, 2017 at 12:33 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> That would indicate that something isn't ever retrying the worker
> start; but if that's the case, how is it that we get through the
> other subscription tests with my random-failure patch in place?

I have been able to dig into this issue further, and the problem is
indeed in the wait logic of 005_encoding.pl. It is important to wait
for the initial sync of the subscriber to happen. There is no need to
incorporate the additional wait query in wait_for_caught_up() as well.
Please see the attached which fixes the stability problems for me even
after forcing failures in launcher.c.
-- 
Michael

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Amit Khandekar
Date:
Subject: Re: [HACKERS] Parallel Append implementation
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] "inconsistent page found" with checksum andwal_consistency_checking enabled