Re: [HACKERS] dblink get_connect_string() passes FDW option"updatable" to the connect string, connection fails. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] dblink get_connect_string() passes FDW option"updatable" to the connect string, connection fails.
Date
Msg-id CAB7nPqSULJYggOtdq=awma7rBkQdUd6RNFCbUFJLXy=OAGGNCg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] dblink get_connect_string() passes FDW option"updatable" to the connect string, connection fails.  (Joe Conway <mail@joeconway.com>)
Responses Re: [HACKERS] dblink get_connect_string() passes FDW option"updatable" to the connect string, connection fails.  (Corey Huinker <corey.huinker@gmail.com>)
List pgsql-hackers
On Mon, Dec 19, 2016 at 6:48 AM, Joe Conway <mail@joeconway.com> wrote:
> Maybe if "CREATE FOREIGN DATA WRAPPER" had a way to specify that the FDW
> supports a libpq connection it would make sense to allows other FDWs
> with this attribute, but since there is none the current state strikes
> me as a bad idea.
>
> Thoughts?

libpq is proper to the implementation of the FDW, not the wrapper on
top of it, so using in the CREATE FDW command a way to do the
decision-making that does not look right to me. Filtering things at
connection attempt is a better solution.
-- 
Michael



pgsql-hackers by date:

Previous
From: Joe Conway
Date:
Subject: Re: [HACKERS] dblink get_connect_string() passes FDW option"updatable" to the connect string, connection fails.
Next
From: Corey Huinker
Date:
Subject: Re: [HACKERS] dblink get_connect_string() passes FDW option"updatable" to the connect string, connection fails.