Re: [HACKERS] Race conditions with WAL sender PID lookups - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Race conditions with WAL sender PID lookups
Date
Msg-id CAB7nPqSTsnK+b53s-NZUuTPosJmjbV+zKHV3zHr7K6ZKFMVY_A@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Race conditions with WAL sender PID lookups  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: [HACKERS] Race conditions with WAL sender PID lookups  (Erik Rijkers <er@xs4all.nl>)
Re: [HACKERS] Race conditions with WAL sender PID lookups  (Noah Misch <noah@leadboat.com>)
Re: [HACKERS] Race conditions with WAL sender PID lookups  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Fri, May 19, 2017 at 3:01 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> Also, as Horiguchi-san pointed out earlier, walreceiver seems need the
> similar fix.

Actually, now that I look at it, ready_to_display should as well be
protected by the lock of the WAL receiver, so it is incorrectly placed
in walreceiver.h. As you are pointing out, pg_stat_get_wal_receiver()
is lazy as well, and that's new in 10, so we have an open item here
for both of them. And I am the author for both things. No issues
spotted in walreceiverfuncs.c after review.

I am adding an open item so as both issues are fixed in PG10. With the
WAL sender part, I think that this should be a group shot.

So what do you think about the attached?
-- 
Michael

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: [HACKERS] OK, so culicidae is *still* broken
Next
From: "David G. Johnston"
Date:
Subject: Re: [HACKERS] Allowing dash character in LTREE