Re: 9.5rc1 brin_summarize_new_values - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: 9.5rc1 brin_summarize_new_values
Date
Msg-id CAB7nPqSHjK6-sp4kipj66uq5TBjg4uebohsfvKWLpMn8-qskLQ@mail.gmail.com
Whole thread Raw
In response to 9.5rc1 brin_summarize_new_values  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: 9.5rc1 brin_summarize_new_values  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, Dec 26, 2015 at 7:10 AM, Jeff Janes <jeff.janes@gmail.com> wrote:
> brin_summarize_new_values() does not check that it is called on the
> correct type of index, nor does it check permissions.

Yeah, it should have those sanity checks... On top of that this is not
a really user-friendly message:
=# select brin_summarize_new_values('brin_example'::regclass);
ERROR:  XX000: cache lookup failed for index 16391
LOCATION:  IndexGetRelation, index.c:3279

What do you think about the attached? This should definitely be fixed
by 9.5.0...
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Performance degradation in commit ac1d794
Next
From: Tom Lane
Date:
Subject: Re: Performance degradation in commit ac1d794