Re: [HACKERS] contrib/bloom wal-check not run by default - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] contrib/bloom wal-check not run by default
Date
Msg-id CAB7nPqSFsKTxMy9z7hR-JqBNM8FLmnAS6SeceHee9PA8+=zwhQ@mail.gmail.com
Whole thread Raw
In response to [HACKERS] contrib/bloom wal-check not run by default  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On Tue, Apr 11, 2017 at 12:14 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> Why $subject?
>
> Does it just need to be wired into the makefiles a bit better?

Looks like an oversight to me. I would suggest changing the Makefile like that:
diff --git a/contrib/bloom/Makefile b/contrib/bloom/Makefile
index 13bd397b70..834ab18bdc 100644
--- a/contrib/bloom/Makefile
+++ b/contrib/bloom/Makefile
@@ -20,5 +20,7 @@ include $(top_builddir)/src/Makefile.globalinclude $(top_srcdir)/contrib/contrib-global.mkendif

-wal-check: temp-install
+check: prove-check
+
+prove-check:   $(prove_check)
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Implementation of SASLprep for SCRAM-SHA-256
Next
From: Fabien COELHO
Date:
Subject: Re: [HACKERS] Variable substitution in psql backtick expansion