Re: pgsql: Refactor Perl test code - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Refactor Perl test code
Date
Msg-id CAB7nPqSFPhDJTM6B5uxDRK5vFmuK2vzwgG5ONXXkSs8HW3=Htg@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Refactor Perl test code  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Refactor Perl test code  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-committers
On Thu, Dec 3, 2015 at 8:38 AM, Tom Lane wrote:
> Test Summary Report
> -------------------
> t/001_initdb.pl (Wstat: 6400 Tests: 8 Failed: 0)
>   Non-zero exit status: 25
>   Parse errors: Bad plan.  You planned 14 tests but ran 8.
> Files=1, Tests=8,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.08 cusr  0.01 csys =  0.11 CPU)
> Result: FAIL
> make[2]: *** [check] Error 1
> make[2]: Leaving directory `/home/postgres/pgsql/src/bin/initdb'
> make[1]: *** [check-initdb-recurse] Error 2
> make[1]: Leaving directory `/home/postgres/pgsql/src/bin'
> make: *** [check-world-src/bin-recurse] Error 2
>
> The buildfarm looks pretty unhappy too, though I've not checked to see if
> it's exactly the same symptom everywhere.

Or in more details:
Undefined subroutine &TestLib::run called at
/Users/mpaquier/git/postgres/src/bin/initdb/../../../src/test/perl/TestLib.pm
line 146.
I am seeing the same failure on all the machines in the buildfarm.

The issue is fixed by the patch attached. This has been visibly
forgotten in the version pushed.
Regards,
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Refactor Perl test code
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Fix broken subroutine call in TestLib