Re: Dead code in win32.h - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Dead code in win32.h
Date
Msg-id CAB7nPqSETfR8GTNBq60_Gs0MEuh1MGoo8F8A4rodZ_7XyQq55A@mail.gmail.com
Whole thread Raw
In response to Re: Dead code in win32.h  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Apr 22, 2016 at 4:52 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wrote:
>> Perhaps I'm missing something, but if so, in what way is the
>> "#if _MSC_VER >= 1600" stanza not totally useless given the
>> immediately preceding macro redefinitions?
>
> Some rummaging in the git history says that that stanza did something
> when it was added (in 63876d3ba), but the later commit 73838b52 made
> it redundant by making the earlier set of definitions unconditional.
> Now it's merely confusing, so I'm going to take it out and repurpose
> the comment.

Going through that... That's indeed dead meat (found a bug on the way actually).
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Should XLogInsert() be done only inside a critical section?
Next
From: Michael Paquier
Date:
Subject: Missing lookup in msvcr120 for pgwin32_putenv