Re: [HACKERS] Something for the TODO list: deprecating abstime and friends - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Something for the TODO list: deprecating abstime and friends
Date
Msg-id CAB7nPqS=ZjG2kJ3UU4iVf907hmkks+onegKFqGF70csA-t=bXw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Something for the TODO list: deprecating abstime and friends  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Something for the TODO list: deprecating abstime and friends
List pgsql-hackers
On Wed, Jul 19, 2017 at 8:56 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wonder if it'd be worth the trouble to stick something like this into
> xlog.c:
>
>         /*
>          * For reliability's sake, it's critical that pg_control updates
>          * be atomic writes.  That generally means the active data can't
>          * be more than one disk sector, which is 512 bytes on common
>          * hardware.  Be very careful about raising this limit.
>          */
>          StaticAssertStmt(sizeof(ControlFileData) <= 512,
>                           "pg_control is too large for atomic disk writes");

+1. Even if it just gets triggered in 20 years by some hacker, that's
a good reminder about assumptions behind the update logic.
-- 
Michael



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] GSoC 2017: Foreign Key Arrays
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump