Re: pg_basebackup stream xlog to tar - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_basebackup stream xlog to tar
Date
Msg-id CAB7nPqS8Uzxg3Vk+6SU9j2jazzAYmHfQFTuc2PwtM+NyyL2eAw@mail.gmail.com
Whole thread Raw
In response to Re: pg_basebackup stream xlog to tar  (Magnus Hagander <magnus@hagander.net>)
Responses Re: pg_basebackup stream xlog to tar  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On Thu, Sep 1, 2016 at 4:41 PM, Magnus Hagander <magnus@hagander.net> wrote:
> That's definitely not intended - it's supposed to be 16Mb. And it actually
> writes 16Mb to the tarfile, it's the extraction that doesn't see them. That
> also means that if you get more than one member of the tarfile at this
> point, it will be corrupt. (It's not corrupt in the .tar.gz case, clearly my
> testing of the very last iteration of the patch forgot to doublecheck this
> with both).
>
> Oops. Will fix.

If at the same time you could add some tests in pg_basebackup/t, that
would be great :)
-- 
Michael



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: pg_basebackup stream xlog to tar
Next
From: Magnus Hagander
Date:
Subject: Re: pg_basebackup stream xlog to tar