Re: Logical Decoding follows timelines - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Logical Decoding follows timelines
Date
Msg-id CAB7nPqS28_Mfj+JzOLuEJVSZNbhyVUnT9q+ULOcQXXGEvB1NVA@mail.gmail.com
Whole thread
In response to Re: Logical Decoding follows timelines  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Logical Decoding follows timelines
List pgsql-hackers


On Wed, Dec 17, 2014 at 5:35 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
On 16 December 2014 at 21:17, Simon Riggs <simon@2ndquadrant.com> wrote:

>>> This patch is a WIP version of doing that, but only currently attempts

>> With the patch, XLogSendLogical uses the same logic to calculate SendRqstPtr
>> that XLogSendPhysical does. It would be good to refactor that into a common
>> function, rather than copy-paste.
>
> Some of the logic is similar, but not all.
>
>> SendRqstPtr isn't actually used for anything in XLogSendLogical.
>
> It exists to allow the call which resets TLI.
>
> I'll see if I can make it exactly identical; I didn't think so when I
> first looked, will look again.

Yes, that works. New version attached

Moved patch to CF 2015-02 to not lose track of it, also because it does not seem it received a proper review.
--
Michael

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: PATCH: hashjoin - gracefully increasing NTUP_PER_BUCKET instead of batching
Next
From: Marko Tiikkaja
Date:
Subject: Re: Patch to support SEMI and ANTI join removal