Re: sequence data type - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: sequence data type
Date
Msg-id CAB7nPqS0e0o__G=7DaOOTt_CA07KF2mu39FF29wb6gQ0fZsYMQ@mail.gmail.com
Whole thread Raw
In response to Re: sequence data type  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On Thu, Mar 30, 2017 at 2:36 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> Over at
> <https://www.postgresql.org/message-id/CAKOSWNnXmM6YBXNzGnXtZQMPjDgJF+a3Wx53Wzmrq5wqDyRX7Q@mail.gmail.com>
> is is being discussed that maybe the behavior when altering the sequence
> type isn't so great, because it currently doesn't update the min/max
> values of the sequence at all.  So here is a patch to update the min/max
> values when the old min/max values were the min/max values of the data type.

Looks sane to me. The only comment I have would be to add a test to
trigger as well the code path of reset_min_value with MINVALUE.
-- 
Michael



pgsql-hackers by date:

Previous
From: "Shinoda, Noriyoshi"
Date:
Subject: Re: Partitioning vs ON CONFLICT
Next
From: Haribabu Kommi
Date:
Subject: Re: pg_stat_wal_write statistics view