Re: [HACKERS] Setting pd_lower in GIN metapage - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Setting pd_lower in GIN metapage
Date
Msg-id CAB7nPqRsyai=oaRVYPX1zCydigEz4awk2orxVGUc+SC2G4p1dQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Setting pd_lower in GIN metapage  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Sep 11, 2017 at 1:26 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> FWIW, now that we've noticed the discrepancy, I'm for using
> REGBUF_STANDARD or equivalent for all metapage calls.  Even if it
> saves no space, inconsistency is bad because it's confusing.

OK, I don't mind having a more aggressive approach, but it would
definitely be nicer if the REGBUF additions are done in a second patch
that can be applied on top of the one setting pd_lower where needed.
Both things are linked, still are aimed to solve different problems.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Still another race condition in recovery TAP tests
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] The case for removing replacement selection sort