Re: [HACKERS] Hang in pldebugger after git commit : 98a64d0 - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Hang in pldebugger after git commit : 98a64d0
Date
Msg-id CAB7nPqRrRwBO7bpUQwZtA=iHnFiH-JJkKmRsqYjN7XT7ZxJi4A@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Hang in pldebugger after git commit : 98a64d0  (Ashutosh Sharma <ashu.coek88@gmail.com>)
Responses Re: [HACKERS] Hang in pldebugger after git commit : 98a64d0  (Ashutosh Sharma <ashu.coek88@gmail.com>)
List pgsql-hackers
On Wed, Dec 14, 2016 at 4:34 PM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
> Attached is the patch based on Amit's explanation above. Please have a
> look and let me know for any concerns. Thank you Micheal and Andres
> for sharing your thoughts and Amit for your valuable inputs.
    }
+    event = &set->events[0];
+    event->events &= ~(WL_SOCKET_READABLE);#ifndef WIN32

I bet that this patch breaks many things for any non-WIN32 platform.
What I think you want to do is modify the flag events associated to
the socket read/write event to be updated in WaitEventAdjustWin32(),
which gets called in ModifyWaitEvent(). By the way, position 0 refers
to a socket for FeBeWaitSet, but that's a mandatory thing when a list
of events is created with AddWaitEventToSet.
-- 
Michael



pgsql-hackers by date:

Previous
From: Ashutosh Sharma
Date:
Subject: Re: [HACKERS] Hang in pldebugger after git commit : 98a64d0
Next
From: Ashutosh Sharma
Date:
Subject: Re: [HACKERS] Hang in pldebugger after git commit : 98a64d0