Re: proposal: function parse_ident - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: proposal: function parse_ident
Date
Msg-id CAB7nPqRn=0rVdS95cGwJospBhTgWm3CZAOuW1v_CtmoO_bWVZQ@mail.gmail.com
Whole thread Raw
In response to Re: proposal: function parse_ident  (Marko Tiikkaja <marko@joh.to>)
Responses Re: proposal: function parse_ident  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, Jan 23, 2016 at 1:25 AM, Marko Tiikkaja <marko@joh.to> wrote:
> Hi Pavel,
>
> Sorry for the lack of review here.  I didn't realize I was still the
> reviewer for this after it had been moved to another commitfest.
>
> That said, I think I've exhausted my usefulness here as a reviewer. Marking
> ready for committer.

+                      errmsg("identifier contains disallowed chars"),
+                      errdetail("string \"%s\" is not valid identifier",
+                                     text_to_cstring(qualname))));
Perhaps, "identifier contains not allowed character" is better?
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: silent data loss with ext4 / all current versions
Next
From: Julien Rouhaud
Date:
Subject: Re: Removing Functionally Dependent GROUP BY Columns