Re: Silly API for do_pg_start_backup() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Silly API for do_pg_start_backup()
Date
Msg-id CAB7nPqRmj9yxUPE+=ygUWwAP+yRwBc+w3J+dPTKrjwo0ZBe0EA@mail.gmail.com
Whole thread Raw
In response to Silly API for do_pg_start_backup()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Dec 5, 2017 at 3:58 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Barring objection I'll remove the tblspcdir parameter and have
> do_pg_start_backup() open and close the directory immediately
> around the loop where it's read, like every other case in the
> backend.

+1. Thanks for the change. What has been committed in 066bc21 looks good to me..
-- 
Michael


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Error handling (or lack of it) in RemovePgTempFilesInDir
Next
From: Tom Lane
Date:
Subject: Re: Error handling (or lack of it) in RemovePgTempFilesInDir