Postgres Pro
Downloads
Home   >   mailing lists

Equivalent of --enable-tap-tests in MSVC scripts - Mailing list pgsql-hackers

From Michael Paquier
Subject Equivalent of --enable-tap-tests in MSVC scripts
Date
Msg-id CAB7nPqRet6UAP2APhZAZw=VhJ6w-Q-gGLdZkrOqFgd2vc9-ZDw@mail.gmail.com
Whole thread Raw
Responses Re: Equivalent of --enable-tap-tests in MSVC scripts  (Craig Ringer <craig@2ndquadrant.com>)
Re: Equivalent of --enable-tap-tests in MSVC scripts  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Tree view 
Hi all,

As of now the MSVC scripts control if TAP tests are enabled or not
using a boolean flag as $config->{tap_tests}. However, this flag is
just taken into account in vcregress.pl, with the following issues:
1) config_default.pl does not list tap_tests, so it is unclear to
users to enable them. People need to look into vcregress.pl as a start
point.
2) GetFakeConfigure() does not translate $config->{tap_tests} into
--enable-tap-tests, leading to pg_config not reporting it in
CONFIGURE. This is inconsistent with what is done in ./configure.

Attached is a patch to address those two issues.
Regards,
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Oleg Bartunov
Date:
Subject: Re: WIP: Upper planner pathification
Next
From: Craig Ringer
Date:
Subject: Timeline following for logical slots