Re: pgsql: Fix two bugs in tsquery @> operator. - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Fix two bugs in tsquery @> operator.
Date
Msg-id CAB7nPqRcaCwafnBfipKzfcsezNa-jYuOhg7kBQQ+hLxjQ6CxzA@mail.gmail.com
Whole thread Raw
In response to pgsql: Fix two bugs in tsquery @> operator.  (Heikki Linnakangas <heikki.linnakangas@iki.fi>)
List pgsql-committers
On Mon, Oct 27, 2014 at 5:52 PM, Heikki Linnakangas
<heikki.linnakangas@iki.fi> wrote:
> Fix two bugs in tsquery @> operator.
>
> 1. The comparison for matching terms used only the CRC to decide if there's
> a match. Two different terms with the same CRC gave a match.
>
> 2. It assumed that if the second operand has more terms than the first, it's
> never a match. That assumption is bogus, because there can be duplicate
> terms in either operand.
>
> Rewrite the implementation in a way that doesn't have those bugs.
>
> Backpatch to all supported versions.
Perhaps the CRC implementation would change in the future, but what
about adding regression tests as well? Those are still bugs.
--
Michael


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix two bugs in tsquery @> operator.
Next
From: Robert Haas
Date:
Subject: pgsql: Add missing equals signs to pg_recvlogical documentation.