Re: [COMMITTERS] pgsql: Fix pg_receivexlog --synchronous - Mailing list pgsql-hackers

On Mon, Aug 29, 2016 at 8:34 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Simon Riggs <simon@2ndQuadrant.com> writes:
>> Fix pg_receivexlog --synchronous
>
> The buildfarm says you broke the 9.5 branch.
>
> In general, pushing inessential patches just a few hours before a wrap
> deadline is a dangerous business.  Pushing them without any testing
> is close to irresponsible.

This area of the code has faced some refactoring from Magnus lately,
so you need this on REL9_5_STABLE:
--- a/src/bin/pg_basebackup/receivelog.c
+++ b/src/bin/pg_basebackup/receivelog.c
@@ -534,7 +534,7 @@ ReceiveXlogStream(PGconn *conn, XLogRecPtr
startpos, uint32 timeline,
    }
    else
    {
-       if (stream->synchronous)
+       if (synchronous)
            reportFlushPosition = true;
        else
            reportFlushPosition = false;
--
Michael