On Mon, Jun 29, 2015 at 3:53 PM, Vladimir Borodin <root@simply.name> wrote:
> 28 июня 2015 г., в 21:46, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> I've committed the additional option to the functions in genfile.c (I
>> renamed it to "missing_ok", for clarity), and the pg_rewind changes to use
>> that option.
>
> And since it changes API it would not be back-ported to 9.4, right?
Those API changes are not going to be back-patched to 9.4 as this is
basically a new feature. For 9.4's pg_rewind, the problem does not
concern this mailing list anyway, so let's discuss it directly on the
project page on github. Just mentioning, but I am afraid that we are
going to need a set of TRY/CATCH blocks with a wrapper function in
plpgsql that does the failure legwork done here, or to export those
functions in an extension with some copy/paste as all the necessary
routines of genfile.c are not exposed externally, and to be sure that
those functions are installed on the source server. I am not sure that
I will be able to look at that in the short term unfortunately...
Hence patches are welcome there and I will happily review, argue or
integrate them if needed. The non-streaming option is not impacted in
any case, so it's not like pg_rewind cannot be used at all on 9.4 or
9.3 instances.
Regards,
--
Michael
