Re: [CF2016-9] Allow spaces in working path on tap-tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [CF2016-9] Allow spaces in working path on tap-tests
Date
Msg-id CAB7nPqRSoXRVbQKXH0AH3M7wK_rp-ZFPi+qevmX2ajn7jQRGkQ@mail.gmail.com
Whole thread Raw
In response to [CF2016-9] Allow spaces in working path on tap-tests  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: [CF2016-9] Allow spaces in working path on tap-tests
List pgsql-hackers
On Mon, Jul 4, 2016 at 4:02 PM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> Hello, this is just an entry mail for the next CF.
>
> The tap-test fails when the soruce directoy containing spaces. I
> accidentially hit this by a Jenkins project with the name "test
> project".
>
> The function system_log() is safe for such parameters but
> backup() uses it in wrong way. On the other hand,
> enable_restoring() and enable_archiving() forgets to quote such a
> path containing spaces as already done for Windows. I don't see
> the similar problem in other places.

Good catch, your fix looks good to me. I am noticing as well that the
invocations of pg_ctl, pg_dumpall, pg_upgrade and diff are likely
broken the same way in vcregress.pl.
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Renaming more clearly SHA functions in pgcrypto/
Next
From: Michael Paquier
Date:
Subject: Re: [CF2016-9] Allow spaces in working path on tap-tests