Postgres Pro
Downloads
Home   >   mailing lists

Missing checks on return value of timestamp2tm in datetime.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Missing checks on return value of timestamp2tm in datetime.c
Date
Msg-id CAB7nPqRSk=J8eUdd55fL-w+k=8sDTHLVBt-cgG9jWN=VO2ogBQ@mail.gmail.com
Whole thread Raw
Responses Re: Missing checks on return value of timestamp2tm in datetime.c  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Tree view
Hi all,

timestamp2tm is called close to 40 times in the backend source code, returning -1 in case of failure. However, there are two places in datetime.c where we do not check for its return value: GetCurrentDateTime and GetCurrentTimeUsec.
This does not really matter much in practice as the timestamp used is GetCurrentTransactionStartTimestamp(), but for correctness shouldn't we check for its return code and report ERRCODE_DATETIME_VALUE_OUT_OF_RANGE on error?

Per se the patch attached.
Regards,
--
Michael

pgsql-hackers by date:

Previous
From: Petr Jelinek
Date:
Subject: Re: Dereferenced pointer in tablesample.c
Next
From: Michael Paquier
Date:
Subject: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel