On Thu, Dec 1, 2016 at 1:24 AM, Christian Ullrich <chris@chrullrich.net> wrote:
> * From: Michael Paquier
>
>> With 0005 I am seeing a compilation failure: you need to have the
>> declarations in the _MSC_VER block at the beginning of the routine. It
>
> Sorry, too used to C++.
>
>> would be nice to mention in a code comment that this what Noah has
>> mentioned upthread: if a CRT loads while pgwin32_putenv() is
>> executing, the newly-loaded CRT will always have the latest value.
>
> I fixed the existing comment by removing the last sentence that is in the wrong place now, but I don't see the point
insuddenly starting to explain why it is done this way and not the other.
>
>> Based on that 0006 will need a rebase, nothing huge though.
>
> Done, new revisions attached.
Okay, switched as ready for committer.
--
Michael
