Re: [BUG] pg_basebackup from disconnected standby fails - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [BUG] pg_basebackup from disconnected standby fails
Date
Msg-id CAB7nPqRQY7_jfL1xKMze3gyLxMdYejC-a1rmx5kW3x7yYGKJgA@mail.gmail.com
Whole thread Raw
In response to Re: [BUG] pg_basebackup from disconnected standby fails  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [BUG] pg_basebackup from disconnected standby fails  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thu, Oct 27, 2016 at 7:16 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> This can create problem if the checkpoint record spans across multiple
> segments, because you are updating minRecoveryPoint to start of
> checkpoint record.  We need to update it to end+1 of checkpoint
> record.  Please find attached patch which takes care of same.

I gave up counting my mistakes on this thread, thanks. You should
update the comments of XLogCtlData for the new field
lastCheckPointEndPtr so as it is not used by the background writer but
when creating a new restart point to define the minimum recovery
point.
-- 
Michael



pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: [PATCH] pgpassfile connection option
Next
From: Mithun Cy
Date:
Subject: Re: Patch: Implement failover on libpq connect level.