Re: Why SyncRepWakeQueue is not static? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Why SyncRepWakeQueue is not static?
Date
Msg-id CAB7nPqRPSk_uoHTJgC3iwTZEexTZM0vd4ygRrxke+Vs+jwQdxQ@mail.gmail.com
Whole thread Raw
In response to Why SyncRepWakeQueue is not static?  (Tatsuo Ishii <ishii@postgresql.org>)
List pgsql-hackers
On Wed, Mar 25, 2015 at 12:13 PM, Tatsuo Ishii <ishii@postgresql.org> wrote:
> SyncRepWakeQueue (src/backend/replication/syncrep.c) is not used
> anywhere except in the file. If there's no good reason for it, I think
> it should be declared as a static function.  Included patch does so.

That's indeed contradictory with what is written in syncrep.h, the
function is not called from other places.
-- 
Michael



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: Auditing extension for PostgreSQL (Take 2)
Next
From: Alvaro Herrera
Date:
Subject: Re: parallel mode and parallel contexts