Re: pg_rewind and log messages - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_rewind and log messages
Date
Msg-id CAB7nPqRG-_-h-X09yUbRDQ+WNN2sC5ugErvtPN8YM654M9Mw2w@mail.gmail.com
Whole thread Raw
In response to Re: pg_rewind and log messages  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: pg_rewind and log messages
List pgsql-hackers
On Mon, Apr 6, 2015 at 1:41 PM, Michael Paquier wrote:
> I guess that you are working on a patch? If not, you are looking for one?

Code-speaking, this gives the patch attached. I eliminated a bunch of
newlines in the log messages that seemed really unnecessary to me,
simplifying a bit the whole. While hacking this stuff, I noticed as
well that pg_rewind could be called as root on non-Windows platform,
that's dangerous from a security point of view as process manipulates
files in PGDATA. Hence let's block that. On Windows, a restricted
token should be used.
Regards,
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Sawada Masahiko
Date:
Subject: Re: Auditing extension for PostgreSQL (Take 2)
Next
From: Simon Riggs
Date:
Subject: Re: TABLESAMPLE patch