Re: skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory)
Date
Msg-id CAB7nPqRFr234mV0O0+FMMkY7YBoGXmSCWpQLSW-PgriAjTc+-w@mail.gmail.com
Whole thread Raw
In response to Re: skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory)  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
List pgsql-hackers
On Thu, Jun 11, 2015 at 2:39 PM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:
> At 2015-06-11 14:28:36 +0900, michael.paquier@gmail.com wrote:
>>
>> After spending the night thinking about that, honestly, I think that
>> we should go with (2) and keep the base backup as light-weight as
>> possible and not bother about a GUC.
>
> OK. Then the patch I posted earlier should be sufficient.

Btw, one thing that 010_pg_basebackup.pl does not check is actually if
the files filtered by basebackup.c are included or not in the base
backup. We may want to add some extra checks regarding that...
Especially with your patch that filters things depending on if
log_directory is an absolute path or not.
-- 
Michael



pgsql-hackers by date:

Previous
From: Abhijit Menon-Sen
Date:
Subject: Re: skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory)
Next
From: Fujii Masao
Date:
Subject: Re: pg_rewind failure by file deletion in source server