On Wed, Aug 24, 2016 at 5:34 AM, Martín Marqués <martin@2ndquadrant.com> wrote:
> Hi,
>
> 2016-08-23 16:46 GMT-03:00 Martín Marqués <martin@2ndquadrant.com>:
>>
>> I will add tests for sequence and functions as you mention and test again.
>>
>> Then I'll check if other tests should be added as well.
>
> I found quite some other objects we should be checking as well, but
> this will add some duplication to the tests, as I'd just copy (with
> minor changes) what's in src/bin/pg_dump/t/002_pg_dump.pl
>
> I can't think of a way to avoid this duplication, not that it really
> hurts. We would have to make sure that any new objects added to one
> test, if needed, are added to the other (that's a bit cumbersome).
>
> Other things to check:
>
> CREATE AGGREGATE
> CREATE DOMAIN
> CREATE FUNCTION
> CREATE TYPE
> CREATE MATERIALIZED VIEW
> CREATE POLICY
>
> Maybe even CREATE INDEX over a table created in the schema.
>
> Also, ACLs have to be tested against objects in the schema.
>
> I hope I didn't miss anything there.
I'll take a look at that soon and review your patch as well as your
tests. For now I have added an entry in the CF app to not lose track
of it:
https://commitfest.postgresql.org/10/736/
--
Michael
