<div dir="ltr"><br /><div class="gmail_extra"><br /><div class="gmail_quote">On Sat, Nov 1, 2014 at 9:04 PM, Petr
Jelinek<span dir="ltr"><<a href="mailto:petr@2ndquadrant.com" target="_blank">petr@2ndquadrant.com</a>></span>
wrote:<br/><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class="">On01/11/14 12:19, Petr Jelinek wrote:<br /><blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px#ccc solid;padding-left:1ex"> Hi,<br /><br /> thanks for review.<br /><br /> On 01/11/14 05:45,
MichaelPaquier wrote:<br /><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">Now here are a couple of comments at code level, this code seems not<br /> enough baked for a
commit:<br/> 1) The following renaming should be done:<br /> - pg_get_transaction_committime to
pg_get_transaction_commit_time<br/> - pg_get_transaction_extradata to pg_get_transaction_extra_data<br /> -
pg_get_transaction_committime_<u></u>datato<br /> pg_get_transaction_commit_<u></u>time_data<br /> -
pg_get_latest_transaction_<u></u>committime_datato<br /> pg_get_latest_transaction_<u></u>commit_time_data<br
/></blockquote><br/> Makes sense.<br /><br /></blockquote><br /></span> On second thought, maybe those should be
pg_get_transaction_committs,pg_get_transaction_committs_data, etc.<br /> For me the commit time thing feels problematic
inthe way I perceive it - I see commit time as a point in time, where I see commit timestamp (or committs for short) as
somethingthat can recorded. So I would prefer to stick with commit timestamp/committs.</blockquote></div>Hehe, I got
exactlythe opposite impression while reading the patch, but let's rely on your judgement for the namings. I am not the
onewriting this code.<br />-- <br /><div class="gmail_signature">Michael<br /></div></div></div>
