Re: Logical Replication Helpers WIP for discussion - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Logical Replication Helpers WIP for discussion
Date
Msg-id CAB7nPqRALUJ_Huwz8G9oSE=YnXFK1rRB2FmtC-7ocTwj0-69iw@mail.gmail.com
Whole thread
In response to Re: Logical Replication Helpers WIP for discussion  (Petr Jelinek <petr@2ndquadrant.com>)
List pgsql-hackers


On Sun, Feb 15, 2015 at 11:25 PM, Petr Jelinek <petr@2ndquadrant.com> wrote:
On 13/02/15 14:04, Petr Jelinek wrote:
On 13/02/15 08:48, Michael Paquier wrote:

Looking at this patch, I don't see what we actually gain much here
except a decoder plugin that speaks a special protocol for a special
background worker that has not been presented yet. What actually is the
value of that defined as a contrib/ module in-core. Note that we have
already test_decoding to basically test the logical decoding facility,
used at least at the SQL level to get logical changes decoded.

Based on those reasons I am planning to mark this as rejected (it has no
documentation as well). So please speak up if you think the contrary,
but it seems to me that this could live happily out of core.

I think you are missing point of this, it's not meant to be committed in
this form at all and even less as contrib module. It was meant as basis
for in-core logical replication discussion, but sadly I didn't really
have time to pursue it in this CF in the end.


That being said and looking at the size of February CF, I think I am fine with dropping this in 9.5 cycle, it does not seem likely that there will be anything useful done with this fast enough to get to 9.5 so there is no point in spending committer resources on it in final CF.

I will pick it up again after the CF is done.

OK, thanks for the clarifications. Note that I am marking it as "rejected" in CF 2014-12 not because it is something that is not wanted, but just not to re-add it to CF 2015-02 which is what "returned with feedback" actually does...
--
Michael

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Optimization for updating foreign tables in Postgres FDW
Next
From: Michael Paquier
Date:
Subject: Re: Commit fest 2015-12 enters money time