On Fri, Nov 7, 2014 at 2:31 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> Julien Rouhaud wrote:
>
>> I just reviewed this patch :
>>
>> * applies cleanly to master(d2b8a2c7)
>> * all regression tests pass
>>
>> As it's only moving functions from builtins.h to quote.h and update
>> impacted files, nothing special to add.
>>
>> It will probably break some user extensions using quote_* functions.
>> Otherwise it looks ready to commit.
>
> I thought the consensus was that the SQL-callable function declarations
> should remain in builtins.h -- mainly so that quote.h does not need to
> include fmgr.h.
Moving everything to quote.h is done in-line with what Tom and Robert
suggested, builtins.h being a refuge for function declarations that
have nowhere else to go. Suggestion from here:
http://www.postgresql.org/message-id/CA+TgmoZF3dkpTuA6Ex6gXLnnd-nMS-fBjCXRoiTwFfH-+6yBQQ@mail.gmail.com
--
Michael
