Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Add GUC to enable compression of full page images stored in WAL. - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Add GUC to enable compression of full page images stored in WAL.
Date
Msg-id CAB7nPqR0azEgsE65kTYpOPziEm3NJyQKpWv3RpL3KhehKUPxHQ@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add GUC to enable compression of full page images stored in WAL.  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-committers
Tree view 
On Thu, Mar 12, 2015 at 7:13 PM, Fujii Masao wrote:
> On Wed, Mar 11, 2015 at 11:30 PM, Michael Paquier wrote:
>> On Wed, Mar 11, 2015 at 11:18 PM, Andres Freund wrote:
>>> I've not checked whether they're spurious or not.
>
> Thanks for the report! We can suppress those warnings just by
> initializing cbimg.hole_length and hole_length. But I'd like to apply
> the attached patch which not only initializes the variable but also
> refactors the related code.

FWIW, I just had a look at this patch, and it looks good to me. Thanks!
--
Michael

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Improve documentation of bt_page_items().
Next
From: Robert Haas
Date:
Subject: pgsql: Document the new custom scan APIs.