Re: Review of Refactoring code for sync node detection - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Review of Refactoring code for sync node detection
Date
Msg-id CAB7nPqR-v_hWgiTGvtOA=tRNoz3zLEM4CgSHdn9yheuGFLXtyw@mail.gmail.com
Whole thread Raw
In response to Re: Review of Refactoring code for sync node detection  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Review of Refactoring code for sync node detection  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Sun, Nov 16, 2014 at 9:07 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> I'll send an updated patch tomorrow.

Here are updated versions. I divided the patch into two for clarity,
the first one is the actual refactoring patch, renaming
SyncRepGetSynchronousNode to SyncRepGetSynchronousStandby (+alpha,
like updating synchronous to sync in the comments as you mentioned)
such as the namings have no conflicts.

The second one updates the syncrep code, including WAL sender and WAL
receiver, and its surroundings to use the term "node" instead of
"standby". This brings in the code the idea that a node using
replication APIs is not necessarily a standby, making it more generic.
This can be applied on top of the refactoring patch. If any other
folks (Heikki or Fujii-san?) have comments about this idea feel free.
Regards,
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: BRIN indexes - TRAP: BadArgument
Next
From: Rajeev rastogi
Date:
Subject: Re: Index scan optimization