Re: [COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys.
Date
Msg-id CAB7nPqQvLv5Bw+F8EdLF6nK8X=szq2R3EqtQ+5MiX5t=-jRNpw@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys.  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: [COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys.  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Thu, Apr 14, 2016 at 5:17 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> On Thu, Apr 14, 2016 at 1:22 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> Yes. I'd prefer avoid a hardcoded sleep and have something that relies
>> on lookups of pg_stat_replication though, because there is no way to
>> be sure that a sleep will ever be stable on heavily loaded machines,
>> like the machines I am specialized in maintaining :)
>> It kills a bit the purpose on having checks on pg_stat_replication as
>> the validation tests are based on that, still I think that we had
>> better base those checks on a loop that has a timeout, something like
>> that in a subroutine:
>> What do you think?
>
> Look good to me. +1.

And so here we go...
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Why doesn't src/backend/port/win32/socket.c implement bind()?
Next
From: Ashutosh Bapat
Date:
Subject: Re: Odd system-column handling in postgres_fdw join pushdown patch