Fixes for a couple of resource leaks - Mailing list pgsql-hackers

From Michael Paquier
Subject Fixes for a couple of resource leaks
Date
Msg-id CAB7nPqQueXppg0CzSHPyF_5x9Nfii4dSCZtMsizPzc2xeB4qoA@mail.gmail.com
Whole thread Raw
Responses Re: Fixes for a couple of resource leaks  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi all,

Coverity is pointing out a couple of resource leaks:
- In DropReplicationSlot@streamutil.c, query is leaked.
- In getTransforms@pg_dump.c, the alloced result of get_language_name is not free'd. Other code paths calling this routine do the job.
- In libpqGetCurrentXlogInsertLocation@libpq_fetch.c (pg_rewind), the value "val" returned by run_simple_query should be free'd. Other code paths do so.
- In libpqProcessFileList@libpq_fetch.c, a call to PQclear is missing for a query result.
- In vacuum_one_database@vacuumdb.c, a call to PQclear is missing.
Attached is a patch to address all those things. Backpatches would be good to have as well.
Regards,
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Re: Removing SSL renegotiation (Was: Should we back-patch SSL renegotiation fixes?)
Next
From: Tom Lane
Date:
Subject: TABLESAMPLE doesn't actually satisfy the SQL spec, does it?