Header and comments describing routines in incorrect shape in visibilitymap.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Header and comments describing routines in incorrect shape in visibilitymap.c
Date
Msg-id CAB7nPqQsQVZbuyjtkGdb5csry-bcp740G2oMPNcQz3yzx4t0xw@mail.gmail.com
Whole thread Raw
Responses Re: Header and comments describing routines in incorrect shape in visibilitymap.c  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Re: Header and comments describing routines in incorrect shape in visibilitymap.c  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hi all,

I just bumped into a couple of things in visibilitymap.c:
- visibilitymap_clear clears all bits of a visibility map, its header
comment mentions the contrary
- The header of visibilitymap.c mentions correctly "a bit" when
referring to setting them, but when clearing, it should say that all
bits are cleared.
- visibilitymap_set can set multiple bits
- visibilitymap_pin can be called to set up more than 1 bit.

This can be summed by the patch attached.
Regards,
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Postgres_fdw join pushdown - wrong results with whole-row reference
Next
From: Michael Paquier
Date:
Subject: Re: Documentation fixes for pg_visibility