Misleading error message in logical decoding for binary plugins - Mailing list pgsql-hackers

From Michael Paquier
Subject Misleading error message in logical decoding for binary plugins
Date
Msg-id CAB7nPqQrqFzjqCjxu4GZzTrD9kpj6HMn9G5aOOMwt1WZ8NfqeA@mail.gmail.com
Whole thread Raw
Responses Re: Misleading error message in logical decoding for binary plugins
List pgsql-hackers
Hi all,

Using a plugin producing binary output, I came across this error:
=# select data from pg_logical_slot_peek_changes('foo', NULL, NULL);
ERROR:  0A000: output plugin cannot produce binary output
LOCATION:  pg_logical_slot_get_changes_guts, logicalfuncs.c:404

Shouldn't the error message be here something like "binary output plugin cannot produce textual output"? The plugin used in my case produces binary output, but what is requested from it with pg_logical_slot_peek_changes is textual output.

A patch is attached (with s/pluggin/plugin in bonus). Comments welcome.
Regards,
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Ali Akbar
Date:
Subject: Re: [REVIEW] Re: Fix xpath() to return namespace definitions
Next
From: Alvaro Herrera
Date:
Subject: Re: Per table autovacuum vacuum cost limit behaviour strange