Re: Free indexed_tlist memory explicitly within set_plan_refs() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Free indexed_tlist memory explicitly within set_plan_refs()
Date
Msg-id CAB7nPqQqSd9zwKNKyFM-tGLe2=dF7HX91X5-c1kDapvvYL1XqA@mail.gmail.com
Whole thread Raw
In response to Free indexed_tlist memory explicitly within set_plan_refs()  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
On Mon, May 25, 2015 at 10:17 AM, Peter Geoghegan <pg@heroku.com> wrote:
> While trying to fix a largely unrelated bug, I noticed that the new
> build_tlist_index() call for the "excluded" targetlist (used by ON
> CONFLICT DO UPDATE queries) does not have its memory subsequently
> freed by the caller. Since every other call to build_tlist_index()
> does this, and comments above build_tlist_index() encourage it, I
> think the new caller should do the same.
>
> Attached patch adds such a pfree() call.

Yep. This looks correct to me.
-- 
Michael



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Run pgindent now?
Next
From: Stefan Kaltenbrunner
Date:
Subject: Re: problems on Solaris